Skip to content

London | 26-ITP-JAN | Kayanat Suleman | Sprint 2 | Form Controls#1086

Open
KayanatSuleman wants to merge 10 commits intoCodeYourFuture:mainfrom
KayanatSuleman:feature/formcontrols
Open

London | 26-ITP-JAN | Kayanat Suleman | Sprint 2 | Form Controls#1086
KayanatSuleman wants to merge 10 commits intoCodeYourFuture:mainfrom
KayanatSuleman:feature/formcontrols

Conversation

@KayanatSuleman
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Added a semantic HTML form using fieldset and legend
  • Added a required full name field with minimum length validation
  • Added a required email field using HTML email validation
  • Added a required colour selection from three predefined options
  • Added a required size selection from six predefined options
  • Ensured all form inputs have associated labels
  • Checked accessibility using Lighthouse (score: 100)

Questions

None yet, happy to make any amendments. Thank you for reviewing.

@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit bba522b
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/698328432cf5f40008422454
😎 Deploy Preview https://deploy-preview-1086--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@KayanatSuleman KayanatSuleman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Jan 27, 2026
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is free of syntax error and well indented. Well done!

I only have a challenge for you (see the inline comment).

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 3, 2026
@KayanatSuleman KayanatSuleman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 4, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 4, 2026

Changes look good. Do you know what the regular expression .*\S.* mean and how it rejects a string containing only space characters?

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 4, 2026
@KayanatSuleman
Copy link
Author

Hi cjyuan, thank you for the additional question. Upon doing some research I found that this is a regex expression which helps to describe what patterns of text are allowed/disallowed. I understand that the "." matches any single character, the "*" means any characters, length or nothing, the "\S" means any non-whitespace character - so the rule becomes - whatever input the user enters must contain at least one non-whitespace character somewhere. I then tested this solution using devtools console to see if I only entered " ", what would happen - this failed as it does not contain a non-space character, the second test was "Ka" - this passes and finally " K " also passes as it satisfies the rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants